Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Astropy Angle support to Master #83

Merged
merged 11 commits into from
Apr 29, 2024

Conversation

Xen0Xys
Copy link
Contributor

@Xen0Xys Xen0Xys commented Apr 23, 2024

No description provided.

@Xen0Xys Xen0Xys marked this pull request as ready for review April 25, 2024 08:27
@Xen0Xys Xen0Xys force-pushed the feature/fov-angle-support branch from a7a36d0 to 42c93ce Compare April 25, 2024 13:57
@@ -1,4 +1,4 @@
import A from "https://esm.sh/aladin-lite@3.3.3-beta";
import A from "https://esm.sh/aladin-lite@3.4.0-beta";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to remove the goToRaDec after initialization with this bump.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this should be in the changelog and in the readme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the version change, the removing of gotoRaDec call at the initialization re-introduce the patched bug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad, thanks for testing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the correspondence table at the end of the README, could you add a line with unreleased || 3.4.0-beta?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because when you instanciate aladin with:

let aladin = Aladin({target: '0 0', cooFrame: 'galactic', ...})

as there is no frame given with the target position string, it will take that position as what is given in the cooFrame.

@tboch - Should we consider that behaviour as okaish or target should be always considered as given in ICRS frame ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the correspondence table at the end of the README, could you add a line with unreleased || 3.4.0-beta?

Done !

src/ipyaladin/__init__.py Outdated Show resolved Hide resolved
src/ipyaladin/__init__.py Show resolved Hide resolved
@Xen0Xys Xen0Xys requested a review from ManonMarchand April 29, 2024 10:44
@bmatthieu3 bmatthieu3 merged commit 501104a into cds-astro:master Apr 29, 2024
2 checks passed
@Xen0Xys Xen0Xys deleted the feature/fov-angle-support branch April 29, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants